Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Register blocks in validator monitor #3635

Closed
wants to merge 5 commits into from

Conversation

tthebst
Copy link
Contributor

@tthebst tthebst commented Oct 8, 2022

Issue Addressed

Closes #3460

Proposed Changes

blocks and block_min_delay are never updated in the epoch summary

@tthebst tthebst changed the base branch from stable to unstable October 8, 2022 13:23
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this too

Just applying a no-op commit in order to re-trigger the branch check

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v3.3.0 Minor release following v3.2.0 labels Nov 9, 2022
@michaelsproul
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Nov 9, 2022

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@michaelsproul
Copy link
Member

bors r-

@michaelsproul
Copy link
Member

Fix CLA

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 9, 2022
## Issue Addressed

Closes #3460

## Proposed Changes

`blocks` and `block_min_delay` are never updated in the epoch summary



Co-authored-by: Michael Sproul <micsproul@gmail.com>
@bors bors bot changed the title Register blocks in validator monitor [Merged by Bors] - Register blocks in validator monitor Nov 9, 2022
@bors bors bot closed this Nov 9, 2022
macladson pushed a commit to macladson/lighthouse that referenced this pull request Jan 5, 2023
## Issue Addressed

Closes sigp#3460

## Proposed Changes

`blocks` and `block_min_delay` are never updated in the epoch summary



Co-authored-by: Michael Sproul <micsproul@gmail.com>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Closes sigp#3460

## Proposed Changes

`blocks` and `block_min_delay` are never updated in the epoch summary



Co-authored-by: Michael Sproul <micsproul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v3.3.0 Minor release following v3.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants